-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/{aws/*,net/http}: fix encoding of http.url #1662
Conversation
32b5d48
to
b301cef
Compare
This PR ensures auth strings are not present in URLs before attaching them to spans in the `http.url` tag
b301cef
to
84c9df9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the test suggestions we discussed offline
5fe9fd8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVED 😎
This PR ensures auth strings are not present in URLs before attaching them to spans in the `http.url` tag
What does this PR do?
This PR ensures auth strings are not present in URLs before attaching them to spans in the
http.url
tagDescribe how to test/QA your changes
Create a traced http client and send a request in the form of
http://abc:[email protected]/whatever
and ensure that the userinfo part (abc:def
) does not appear in thehttp.url
tag in the UI.This is likely not possible to test with the AWS integration, however the case has been covered by unit/regression tests.
Reviewer's Checklist
Triage
milestone is set.